[Fix] 세모피드 image_url이 따옴표("")와 함께 저장되는 버그 수정#150
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 SemoFeed 생성 시 image_url이 따옴표와 함께 저장되는 버그를 수정합니다. Jackson의 JSON 파싱 기능을 올바르게 활용하기 위해 DTO를 도입하였으며, 이로 인해 프론트엔드에서 보내는 요청 본문 형식이 raw string에서 JSON 객체로 변경되어야 합니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the raw @RequestBody String with a structured SemoFeedCreateRequest DTO in the SemoFeedController's create endpoint to allow Jackson to correctly parse and strip quotes from the imageUrl JSON string. The reviewer suggests improving the new DTO by adding @URL validation to ensure the image URL format is correct, adding Swagger @Schema annotations for better API documentation, and fixing a minor spacing issue in the validation error message.
pooreumjung
changed the title
2 participants
🧾 요약
@RequestBody String대신 DTO를 사용해 image_url이 따옴표("")와 함께저장되는 버그 수정
🔗 이슈
✨ 변경 내용
SemoFeedCreateRequestDTO 추가 (imageUrl필드,@NotBlank검증)SemoFeedController,SemoFeedControllerDocscreate 메서드 파라미터를String→SemoFeedCreateRequest로 교체✅ 확인